Weird behaviour for 0.5.3

[dashed]

I cloned this repo and created some file:

var es = require('event-stream');
var plumber = require('./');

var badBoy = es.through(function(data) {
    if(data % 2 == 0)
        return this.emit('error', new Error(data));

    this.emit('data', data);
});

es.readArray([1,2,3,4,5,6])
    .pipe(plumber())
    .pipe(badBoy)
    .pipe(es.through(console.log))

Output:

1
[gulp] Plumber found unhandled error: Error: 4
[gulp] Plumber found unhandled error: Error: 6

If I use gulp-plumber@0.4.1 using same code, I get output:

1
[gulp] Plumber found unhandled error: Error: 2
3
[gulp] Plumber found unhandled error: Error: 4
5
[gulp] Plumber found unhandled error: Error: 6

[floatdrop]

This is issue with this line: if (EE.listenerCount(this, 'error') < 3). I outputed listeners and this is what I see:

1
[ [Function: onerror2], [Function], [Function: onerror] ]
[ [Function: onerror2], [Function] ]
[gulp] Plumber found unhandled error: Error: 4
[ [Function: onerror2], [Function] ]
[gulp] Plumber found unhandled error: Error: 6

Some how default onerror is still there, but it should'nt.

[dashed]

Oh ah. I found that unusual behaviour when I made the continueOnError hack.

[floatdrop]

@dashed seems like streams in 0.10 reattaching onerror handler inside, this patchPipe function fixes your code samples:

    function patchPipe(stream) {
        if (stream.pipe2) {
            removeDefaultHandler(stream, 'error');
            stream._pipe = stream._pipe || stream.pipe;
            stream.pipe = stream.pipe2;
            stream.once('readable', patchPipe.bind(null, stream));
            stream._plumbed = true;
        }
    }

[dashed]

I get same output for 0.5.4:

1
[gulp] Plumber found unhandled error: Error: 4
[gulp] Plumber found unhandled error: Error: 6

But if it attach error listener:

es.readArray([1,2,3,4,5,6])
    .pipe(plumber())
    .pipe(badBoy)
        .on('error', console.log)
    .pipe(es.through(console.log))

I get output:

1
[Error: 2]
[Error: 4]
[Error: 6]

[floatdrop]

Closed in 0.5.6