Fix lint #182
Merged
Fix lint #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, will merge after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
standardrun. It was mostly just runningstandard --fix. But changes in main/signers/hot/RingSigner/worker.js and in main/signers/hot/SeedSigner/worker.js had to be made by hand.As far as I understand the logic, this is just initialisation code to run the code in the constructor. So theoretically, we could omit the variable declaration and just run
new SeedSignerWorker(). But then, Eslint will throw the Do not use 'new' for side effects.. So I just ignore this line with// eslint-disable-line, but it would probably be cleaner to refactor the code so that the constructor does not have side effects: Moveprocess.on('message', (message) => this.handleMessage(message))outside of the constructor and run it directly on the files root level:process.on('message', (message) => seedSignerWorker.handleMessage(message))Thoughts? @monkybrain