Initialise Tensorflow submodule to correct version in CMake builds #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenBE
approved these changes
Jul 2, 2021
| endif() | ||
|
|
||
| # find Git and use it to get backscrub version | ||
| find_package(Git) | ||
| if(GIT_FOUND) | ||
| execute_process( |
There was a problem hiding this comment.
IMHO git describe --long --tags --always --dirty gives more descriptive results …
There was a problem hiding this comment.
You may be right, I'm not really fussed.. I tried both on current main and experimental branches:
% git checkout experimental
...
% git describe --long --always --dirty --all
heads/experimental-0-gaa243fc
% git describe --long --always --dirty --tags
v0.3.0-7-gaa243fc
% git checkout main
...
% git describe --long --always --dirty --all
heads/main-0-g7ec492c
% git describe --long --always --dirty --tags
7ec492cI would note that this is not changed by this PR 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #92, our CMake builds don't pull Tensorflow source like the Makefile does, this fixes it.