openflow_input: add bsn_generic_stats extension #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test PASSed. |
| uint32_t xid; | ||
| uint16_t stats_type == 0xffff; | ||
| enum ofp_stats_request_flags flags; | ||
| pad(4); |
There was a problem hiding this comment.
is this padding necessary?
|
looks good to me. just a minor comment on padding. |
|
SELF-ACK |
|
ABAT: START_MERGE: Log file at http://vss1/abat/2014.12.08.2331-m.loxigen.master/abat.log |
bsn-abat
pushed a commit
to floodlight/loxigen-artifacts
that referenced
this pull request
Dec 8, 2014
Loxigen Head commit floodlight/loxigen@61b9ba3 commit 61b9ba324653699d01a97c0031bea9710ba6e62d Merge: 8a3d9fb a498795 Author: abat <abat@bigswitch.com> Date: Mon Dec 8 15:31:30 2014 -0800 Merge into master from pull request #364: openflow_input: add bsn_generic_stats extension (floodlight/loxigen#364) commit a4987959e42eb2ae99d8c53bc09d18bb9bf1aafc Author: Rich Lane <rlane@bigswitch.com> Date: Mon Dec 8 13:01:50 2014 -0800 openflow_input: add bsn_generic_stats extension
bsn-abat
pushed a commit
that referenced
this pull request
Dec 8, 2014
openflow_input: add bsn_generic_stats extension (#364)
|
ABAT: ACCEPT: Successfully merged In case you want to see the build log, check out : |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @wilmo119