Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix to support ports > 32768 #375

Merged
merged 1 commit into from
Jan 13, 2015
Merged

fix to support ports > 32768 #375

merged 1 commit into from
Jan 13, 2015

Conversation

alshabib
Copy link
Contributor

Ports numbers greater than 32768 where being reported as negative.

@bsn-abat
Copy link

Can one of the admins verify this patch?

@rlane
Copy link
Contributor

rlane commented Jan 12, 2015

@Sovietaced please take a look.

@Sovietaced
Copy link
Contributor

@rlane it looks good to me. I'm just wondering if there is a historical reason why we haven't changed this sooner.

@rizard
Copy link
Contributor

rizard commented Jan 13, 2015

@rlane, @Sovietaced FWIW, looks good to me too.

On Mon, Jan 12, 2015 at 3:33 PM, Jason Parraga notifications@github.com
wrote:

@rlane https://github.com/rlane it looks good to me. I'm just wondering
if there is a historical reason why we haven't changed this sooner.

—
Reply to this email directly or view it on GitHub
#375 (comment).

@rlane
Copy link
Contributor

rlane commented Jan 13, 2015

ACK

@bsn-abat
Copy link

ABAT: START_MERGE: Log file at http://vss1/abat/2015.01.13.2054-m.loxigen.master/abat.log

bsn-abat pushed a commit to floodlight/loxigen-artifacts that referenced this pull request Jan 13, 2015
Artifacts from floodlight/loxigen@346d40d...5518882
1c50303 
Loxigen Head commit floodlight/loxigen@5518882
commit 551888298a26526816b79183114c8851d5ca509d
Merge: 346d40d bb66cd5
Author: abat <abat@bigswitch.com>
Date:   Tue Jan 13 12:54:31 2015 -0800

    Merge into master from pull request #375:
    fix to support ports > 32768 (floodlight/loxigen#375)

commit bb66cd52ad0c947b1761ac859a4b5a4770c37e34
Author: alshabib <alshabibi.ali@gmail.com>
Date:   Mon Jan 12 11:59:56 2015 -0800

    fix to support ports > 32768
@bsn-abat bsn-abat merged commit bb66cd5 into floodlight:master Jan 13, 2015
bsn-abat pushed a commit that referenced this pull request Jan 13, 2015
Merge into master from pull request #375:
5518882 
fix to support ports > 32768 (#375)
@bsn-abat
Copy link

ABAT: ACCEPT: Successfully merged

In case you want to see the build log, check out :
Log file at http://vss1/abat/2015.01.13.2054-m.loxigen.master/abat.log
/cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alshabib @bsn-abat @rlane @Sovietaced @rizard