Another fix for OFGroup.java #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… instead of OFGroup.of(ZERO_VAL) works. It's null otherwise, which makes sense.
|
@Sovietaced please take a look. |
|
That would explain the NPE on the builder. thanks @rizard |
|
Refer to this link for build results (access rights to CI server needed): |
|
ACK |
|
ABAT: START_MERGE: Log file at http://vss1/abat/2015.05.14.2206-m.loxigen.master/abat.log |
bsn-abat
pushed a commit
to floodlight/loxigen-artifacts
that referenced
this pull request
May 14, 2015
Loxigen Head commit floodlight/loxigen@4cbe0e5 commit 4cbe0e565453307bbeb9fe32c16f560f81971e44 Merge: 5d668c3 cc196ab Author: abat <abat@bigswitch.com> Date: Thu May 14 15:06:28 2015 -0700 Merge into master from pull request #398: Another fix for OFGroup.java (floodlight/loxigen#398) commit cc196ab13b8ad58cdc24321e62b3010b0a1efabf Author: Ryan Izard <ryan.izard@bigswitch.com> Date: Thu May 14 17:27:55 2015 -0400 Well, that introduced another subtle bug. Using new OFGroup(ZERO_VAL) instead of OFGroup.of(ZERO_VAL) works. It's null otherwise, which makes sense.
|
ABAT: ACCEPT: Successfully merged In case you want to see the build log, check out : |
bsn-abat
pushed a commit
that referenced
this pull request
May 14, 2015
Another fix for OFGroup.java (#398)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer: @rlane
Well, that introduced another subtle bug. Using "new OFGroup(ZERO_VAL)" instead of "OFGroup.of(ZERO_VAL)" is the correct way to instantiate the ZERO object. It's null otherwise, which makes sense.