Change toString() of OFMetadata #427
Conversation
…fore the value. No other type does this to my knowledge. We should probably remove it to be consistent with e.g. MacAddress, which is a hex string 'XX:XX:XX:XX:XX:XX', not 'MAC Address: XX:XX:XX:XX:XX:XX'.
|
ABAT: AUTO-REJECT: no reviewer specified in pull request description INSTRUCTIONS: Please fix your problem by
Under certain situations the requester can approve his/her own change. To do that, just include a single word of "SELF-ACK" (without quotes) in a line by itself. You are trusted not to abuse it :) Any code review approval or new comment including the magic line of "R_E_T_R_Y" (Remove the underscores) will cause abat to automatically try to merge your code again. |
|
Refer to this link for build results (access rights to CI server needed): |
|
ACK |
|
ABAT: START_MERGE: Log file at http://vss1/abat/2015.10.26.1731-m.loxigen.master/abat.log |
Loxigen Head commit floodlight/loxigen@b3b3cfd commit b3b3cfd16d43bea9a59a40e185b58781ace14ad2 Merge: 8b8ac26 5bc9c8c Author: abat <abat@bigswitch.com> Date: Mon Oct 26 10:31:43 2015 -0700 Merge into master from pull request #427: Change toString() of OFMetadata (floodlight/loxigen#427) commit 5bc9c8cc8570b752b20e2f43915c6bc027a2de6e Author: Ryan Izard <ryan.izard@bigswitch.com> Date: Mon Sep 28 08:30:15 2015 -0400 Fix toString() of OFMetadata to not include the string 'Metadata:' before the value. No other type does this to my knowledge. We should probably remove it to be consistent with e.g. MacAddress, which is a hex string 'XX:XX:XX:XX:XX:XX', not 'MAC Address: XX:XX:XX:XX:XX:XX'.
Change toString() of OFMetadata (#427)
|
ABAT: ACCEPT: Successfully merged In case you want to see the build log, check out : |
Reviewer: @rlane
Change toString() of OFMetadata to not include the string 'Metadata:' before the value. No other type does this to my knowledge. We should probably remove it to be consistent with e.g. MacAddress, which is a hex string 'XX:XX:XX:XX:XX:XX', not 'MAC Address: XX:XX:XX:XX:XX:XX'.