Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Python error on "fips diag fips" if Git not in path #28

Closed
code-disaster opened this issue Jan 17, 2015 · 1 comment
Closed

Comments

@code-disaster
Copy link
Contributor

Only a minor annoyance, but I don't have Git added to the system path on my Windows system. This is easily avoidable by using Git Bash instead of cmd.exe, but maybe you want to add a check for this.

=== tools:
git: NOT FOUND (git not found in path, can't happen(?))

=== fips:
[...]
File "D:\projects\noise-fips/fips\mod\tools\git.py", line 50, in get_branches
output = subprocess.check_output(['git', 'branch', '-vv'], cwd=proj_dir)
File "C:\Python27\lib\subprocess.py", line 566, in check_output
process = Popen(stdout=PIPE, _popenargs, *_kwargs)
[...]
WindowsError: [Error 2] Das System kann die angegebene Datei nicht finden

@floooh floooh closed this as completed in 7f69b87 Jan 17, 2015
@floooh
Copy link
Owner

floooh commented Jan 17, 2015

Thanks! I have added a check around git operations, but only tested on OSX so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants