Fix the issue of inability to start on Android 14

[Comanx]

Fix the issue where setting android:exported="true" is required to start an Activity on Android 14

[floooh]

Thanks! But hmm, reading the documentation here: https://developer.android.com/privacy-and-security/risks/android-exported

...shouldn't it rather be android:exported="false"?

I'm still on Android 13 on my phone. Will check if there's an update to Android 14 available and tinker around with that fix before merging. Might be a few days.

[Comanx]

https://developer.android.com/about/versions/12/behavior-changes-12#exported
"If the app component includes the LAUNCHER category, set android:exported to true. In most other cases, set android:exported to false."

[floooh]

Giving this a quick test now (on an Android 13 phone though, so just checking if it also works on 13).

[floooh]

Blargh, somehow my Android phone is no longer detected when I connect it to my Mac. Probably a latest-macOs-thing. I try to investigate.

[Comanx]

You can change ANDROID_PLATFORM: android-28 to android-31, it should not start on Android 13

[floooh]

Hmm ok, what is the behaviour on Android 14 when using ANDROID_PLATFORM: android-28 without the export manifest item?

E.g. is export actually needed for platform-31 apps, regardless of the Android OS version?

(because in that case we should consider switching all defaults to platform-31 together with the export fix)

[Comanx]

because "If your app targets Android 12 or higher and contains activities, services, or broadcast receivers that use intent filters, you must explicitly declare the android:exported attribute for these app components."
https://developer.android.com/about/versions/12/behavior-changes-12#exported

[floooh]

Ah right I see, because the manifest that's generated by fips has an intent-filter field.

I'm currently still not able to test on my phone, but I will just merge the PR.

Does the change require to update the platform in the build configs to platform-31 though?

(for instance here:

fips/configs/android-ninja-debug.yml

Line 9 in c050398

ANDROID_PLATFORM: android-28

)

If yes we should probably do this too in this PR?

[floooh]

...I'm actually able to test now... had to update the Android platform-tools and reboot my Mac (not just 'adb kill-server')

[floooh]

Ok merged. Many thanks!

I tested with only the fix (e.g. keeping platform-28), and that seems to work on my Android 13 device.

[Comanx]

Ah right I see, because the manifest that's generated by fips has an intent-filter field.

I'm currently still not able to test on my phone, but I will just merge the PR.

Does the change require to update the platform in the build configs to platform-31 though?

(for instance here:

fips/configs/android-ninja-debug.yml

Line 9 in c050398

ANDROID_PLATFORM: android-28

)
If yes we should probably do this too in this PR?

yes, that sounds good. considering that Google Play requires a minimum target API level of 33.
https://support.google.com/googleplay/android-developer/answer/11926878?hl=en

[floooh]

Ok, fips should eventually update its default platform in the build configs, but since that can also be configured by the user it's not so high priority IMHO.

Thanks for all the info btw :)

[floooh]

PS: as you can see I have merged the your PR without updating the default platform, but if you feel like it, feel free to provide a PR for fips to update to platform-33.

Note that this doesn't only require updating the build config files, but also the installed platform package here:

fips/mod/android.py

Line 120 in 3064811

install_package(fips_dir, '"platforms;android-28"')

I currently don't have all that much time to look into Android specific things.