Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cimgui a module under a directory dependency #1

Merged
merged 2 commits into from
Jun 1, 2024
Merged

Make cimgui a module under a directory dependency #1

merged 2 commits into from
Jun 1, 2024

Conversation

geooot
Copy link
Contributor

@geooot geooot commented May 31, 2024

  • Removes cimgui folder
  • Creates deps/cimgui dependency which takes c source of cimgui and imgui and makes a static library out of it
  • Ran translate-C on cimgui.h as a build step so that you don't need to inline it in the main.zig source
  • Changed root build zig to use the new dependency

@geooot geooot changed the title Use zig package manager for cimgui dependency Make cimgui a module under its own local dependency Jun 1, 2024
@geooot geooot changed the title Make cimgui a module under its own local dependency Make cimgui a module under a directory dependency Jun 1, 2024
@floooh
Copy link
Owner

floooh commented Jun 1, 2024

Thanks! Giving this a whirl now. I'll probably change the commit shas in build.zig.zon to more readable git tag names.

@floooh floooh merged commit 66d5151 into floooh:main Jun 1, 2024
@floooh
Copy link
Owner

floooh commented Jun 1, 2024

Btw, is ziphfile a typo or does that have a specific meaning? :)

const ziphfile = cimgui_dep.path("cimgui.h");

@floooh
Copy link
Owner

floooh commented Jun 1, 2024

Really loving the PR, thanks a lot :)

@geooot
Copy link
Contributor Author

geooot commented Jun 1, 2024

Btw, is ziphfile a typo or does that have a specific meaning? :)

const ziphfile = cimgui_dep.path("cimgui.h");

@floooh Ah that was a copy paste error on my part. The variable represents the path to the header file. Probably "cimgui_h" is a better name.

@floooh
Copy link
Owner

floooh commented Jun 1, 2024

Ok I'll change that. Otherwise everything merged and ready to go.

@geooot geooot deleted the no-cimgui-dir branch June 2, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants