Make the custom Emscripten SDK build steps more 'idiomatic' #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
floooh
commented
Jun 2, 2024
•
floooh
commented
- for Run steps, simply use addArg() and addArgs() instead of building an array of args
- fix the Emscripten linker run step to be "build system idiomatic": proper output arg so that dirty checks work as expected, and linker output first goes into the regular zig cache, and is then installed with an InstallDir step
kassane
added a commit
to kassane/sokol-d
that referenced
this pull request
Jun 2, 2024
kassane
added a commit
to kassane/sokol-d
that referenced
this pull request
Jun 2, 2024
* sokol_fetch support & new example * fix emsdk setup and link, by @floooh (ref.: floooh/sokol-zig#70)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.