Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cases where failing to create a backend resource doesn't result in SG_RESOURCESTATE_FAILED. #884

Closed
floooh opened this issue Sep 13, 2023 · 3 comments
Closed

Fix cases where failing to create a backend resource doesn't result in SG_RESOURCESTATE_FAILED. #884

floooh opened this issue Sep 13, 2023 · 3 comments
Assignees
@floooh
Labels
bug

Comments

@floooh
Copy link
Owner

floooh commented Sep 13, 2023

See: #883
@floooh floooh self-assigned this Sep 13, 2023
@floooh floooh added the bug label Sep 13, 2023
@floooh floooh mentioned this issue Sep 13, 2023
Closed
@floooh
Copy link
Owner Author

floooh commented Sep 18, 2023

Fixed for Metal, but in GL or WebGPU this isn't really fixable for out-of-memory situations. In GL, calling glGetError() causes a full pipeline flush in WebGL, and with WebGPU's asynchronous error reporting it's also not possible to immediately return an out-of-memory error at object creation time.

@floooh
Copy link
Owner Author

floooh commented Sep 18, 2023

PR: #894

@floooh
Copy link
Owner Author

floooh commented Sep 18, 2023

Fixed.

@floooh floooh closed this as completed Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@floooh floooh

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@floooh