sokol_nuklear.h: change snk_handle_event to return a bool if handled #959
Conversation
This method was recommended by @vurtun: vurtun/nuklear#189 (comment) This is an older comment but the functionality works as expected.
|
Related: Why does the current code store the state in new frame, but then apply it in event handling. Why not just do it all in the event handling instead of carrying the state through. |
|
If there is anything you would like adjusted or changed, please let me know @floooh |
|
Starting to look into the PR later today, apologies for the delay. |
|
No apology necessary. Thanks for taking the time. |
|
...please ignore the failed Emscripten CI run, unrelated to the PR and already fixed in master. |
IFIR the sokol_nuklear.h header was mostly copied over from sokol_imgui.h by the original author (sokol_imgui.h has diverged in the meantime because the Dear ImGui input model has changed to input events -> to fix exactly the problems which made this per-frame code necessary in the first place). Specifically for mouse buttons, it was necessary to delay a button-up into the next frame, otherwise on touchpads it would frequently happen that at button-down happened in the same frame as button up, which caused at least Dear ImGui to miss the event (and I think Nuklear suffered from the same problem). |
|
...and merged. Thanks! I also added a small blurb to the changelog. |
This method was recommended by @vurtun: vurtun/nuklear#189 (comment)
This is an older comment but the functionality works as expected.