Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple output formats, by specifying f several times #111

Merged
merged 1 commit into from
Jan 16, 2016

Conversation

SuzanneSoy
Copy link
Contributor

Use-case:

raco cover -f html -f coveralls file.rkt

Note that I didn't add a test for that case, but since the only two output formats I know of are html and coveralls, it doesn't seem like to make much sense to run coveralls on a test file, does it?

… command-line, e.g. `raco cover -f html -f coveralls file.rkt`.
@SuzanneSoy
Copy link
Contributor Author

I removed the define/contract (and reverted the (require racket/contract/base)). get-formats already wraps its results in a contract, did you mean that something else should be done?

Concerning output-formats always being a list, the first occurrence of -f should clear the default value, and subsequent occurrences will add to the list. Right now I'm distinguishing the default value because it's not a list, so if I were to make it always be a list (not a breaking change, as you say it's not exposed to the API), then I suppose I would need to add an extra boolean to track whether it's the default value or not. Should I do that?

@florence florence merged commit 64cd769 into florence:master Jan 16, 2016
@florence
Copy link
Owner

Fair enough, merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants