Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tooling, including dealing w/ Python 3.7 EOL #247

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

florimondmanca
Copy link
Owner

@florimondmanca florimondmanca commented Sep 12, 2023

Our yearly tooling and packaging refresher!

This PR gets this package up to date with the latest packaging and tooling practices...

  • Remove flake8 and isort in favor of ruff
  • Use pyproject.toml
  • Use build (PEP 517)
  • Use latest CI template, update Makefile accordingly

Also does the following:

  • Drop 3.7 support, as it is EOL since June 2023 (and e.g. latest wheel can't be installed on it)
  • Test on Python 3.11
  • Update dev dependencies, deal with django-test-migrations not supporting Django < 3.2
  • Update guide.md installation instructions to be in line with README.md
  • Use Postgres 15 on CI (11 is outdated)

@florimondmanca florimondmanca added the tooling Issues and PRs related to tools, CI, tests, etc. label Sep 12, 2023
@@ -40,17 +39,6 @@ def test_if_valid_api_key_custom_header_then_permission_granted(
assert response.status_code == 200


@pytest.mark.parametrize("hasher", PASSWORD_HASHERS)
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a leftover from #244 which I didn't see before.

We don't need this test anymore now that we always use SHA512.

@florimondmanca florimondmanca force-pushed the chore/packaging branch 3 times, most recently from a495e8e to db62771 Compare September 12, 2023 21:54
@florimondmanca florimondmanca changed the title Upgrade tooling Upgrade tooling, including dealing w/ Python 3.7 EOL Sep 12, 2023
@florimondmanca florimondmanca added docs Request for documentation dependencies Pull requests that update a dependency file labels Sep 12, 2023
@florimondmanca florimondmanca force-pushed the chore/packaging branch 5 times, most recently from 79258f6 to f2fab1e Compare September 12, 2023 22:10
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2023

Codecov Report

Merging #247 (b37ca59) into master (f707b0c) will not change coverage.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff            @@
##            master      #247   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        24    -1     
  Lines          629       622    -7     
=========================================
- Hits           629       622    -7     
Files Changed Coverage Δ
src/rest_framework_api_key/crypto.py 100.00% <ø> (ø)
.../rest_framework_api_key/migrations/0001_initial.py 100.00% <ø> (ø)
...work_api_key/migrations/0002_auto_20190529_2243.py 100.00% <ø> (ø)
...work_api_key/migrations/0003_auto_20190623_1952.py 100.00% <ø> (ø)
...work_api_key/migrations/0005_auto_20220110_1102.py 100.00% <ø> (ø)
tests/test_permissions.py 100.00% <ø> (ø)
src/rest_framework_api_key/__init__.py 100.00% <100.00%> (ø)
...ework_api_key/migrations/0004_prefix_hashed_key.py 100.00% <100.00%> (ø)
tests/test_migrations.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@florimondmanca florimondmanca merged commit 3a1609f into master Sep 12, 2023
7 checks passed
@florimondmanca florimondmanca deleted the chore/packaging branch September 12, 2023 22:25
@florimondmanca florimondmanca mentioned this pull request Sep 12, 2023
@florimondmanca florimondmanca mentioned this pull request Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file docs Request for documentation tooling Issues and PRs related to tools, CI, tests, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants