Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I use your library in my side project and really like it so far. Great solution for mocking typed code, especially with es6 proxy mocks!
That being said I encountered small issues, so here is my proposition of fix:
Calling proxied function (dynamic mock implemented with es6 proxy to be precise) is impossible right now.
Code
will thow error
fn is not a function
.It turns out es6 proxy will be callable only if proxied object is callable.
It means that in your library line:
should be changed to
Note that this is more general, since every function is an object - all dynamic object mocks will still work, and error about fn not being function will disappear.
Thanks in advance and have a great day!