Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Improve placement of $FlowExpectedErrors in @babel/* packages #4559

Merged
merged 1 commit into from
Dec 19, 2023
Merged

refactor: Improve placement of $FlowExpectedErrors in @babel/* packages #4559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion definitions/npm/@babel/polyfill_v7.x.x/flow_v0.104.x-/test_polyfill_v7.x.x.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ import '@babel/polyfill';
// This should fail but couldn't make it to do so
import defaultValue from '@babel/polyfill';

// $FlowExpectedError does not export anything
// $FlowExpectedError[missing-export] does not export anything
import { namedExport } from '@babel/polyfill';
2 changes: 1 addition & 1 deletion definitions/npm/@babel/polyfill_v7.x.x/flow_v0.30.x-v0.103.x/test_polyfill_v7.x.x.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ import '@babel/polyfill';
// This should fail but couldn't make it to do so
import defaultValue from '@babel/polyfill';

// $FlowExpectedError does not export anything
// $FlowExpectedError[missing-export] does not export anything
import { namedExport } from '@babel/polyfill';
10 changes: 4 additions & 6 deletions definitions/npm/@babel/register_v7.x.x/flow_v0.104.x-/test_register_v7.x.x.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { describe, it } from 'flow-typed-test';

describe('unknown properties', () => {
it('are not allowed', () => {
// $FlowExpectedError does not accept unknown props
// $FlowExpectedError[prop-missing] does not accept unknown props
require('@babel/register')({
unknown: 'property'
});
Expand All @@ -20,14 +20,12 @@ describe('plugins', () => {
});
});
it('does not accept anything else', () => {
// $FlowExpectedError no numbers
require('@babel/register')({
plugins: [
123
]
// $FlowExpectedError[incompatible-call] no numbers
plugins: [123]
});
// $FlowExpectedError should be array
require('@babel/register')({
// $FlowExpectedError[incompatible-call] should be array
plugins: 'my-plugin'
});
})
Expand Down
Loading