Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TouchEvent support #365

Merged
merged 6 commits into from
Aug 17, 2017
Merged

Fix TouchEvent support #365

merged 6 commits into from
Aug 17, 2017

Conversation

jonnor
Copy link
Member

@jonnor jonnor commented Aug 17, 2017 •
edited
Loading

Affects iOS devices

bergie and others added 6 commits August 16, 2017 17:33
@bergie
QnD fix for defining TouchInput, refs #364
50e635e
@jonnor
showContext: Also handle TouchEvent
d931ae9 
For mobile devices without PointerEvent support
@jonnor
the-graph-app: Use getDefaultProps function
6690702 
Think defaultProps is only used for ES6 classes
@jonnor
Fix panning graph with TouchEvent
c8e4b56 
These don't have the relative coordinates movementY/X,
so instead we use the motion-since-gesture start from HammerJS
@jonnor
the-graph-group: Fix moving with TouchEvent
dba4f9d
@jonnor
the-graph-node: Fix movement with TouchEvent
cd5bddc 
Using HammerJS gesture data and keeping track of relative
@bergie
Copy link
Member

bergie commented Aug 17, 2017

@jonnor dragging nodes and pinch-zoom both work on iOS. Making edges also works, though is a pretty tricky to hit the small target. However, if I long-press a node, menu doesn't show up, and after that dragging and zooming is also dead

@jonnor
Copy link
Member Author

jonnor commented Aug 17, 2017

Any exceptions? Any console output? Does this only happen when opening menu on a node, or also on the background or an edge?

@bergie
Copy link
Member

bergie commented Aug 17, 2017 •
edited
Loading

@jonnor TypeError: null is not an object (evaluating 'this.props.menus[options.type]')

(this is with examples/simple.html)

@jonnor
Copy link
Member Author

jonnor commented Aug 17, 2017

Thats probably fixed by 72af77b
It should not happen in demo-full.html. Can you verify?

@bergie
Copy link
Member

bergie commented Aug 17, 2017

@jonnor can verify fully working in demo-full.html. Great work! Works also nicely with the Apple Pencil (which does supply some extra data, but I don't think we have uses for that so far)

bergie
bergie approved these changes Aug 17, 2017
View reviewed changes
Copy link
Member

@bergie bergie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you release these fixes?

@jonnor jonnor merged commit 552f1f4 into master Aug 17, 2017
@jonnor jonnor deleted the fix_touch branch August 17, 2017 14:03
This was referenced Aug 17, 2017
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergie bergie bergie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonnor @bergie