Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop use of deprecated network.external.name #34

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

kdambekalns
Copy link
Member

The config claims to be version 3.7, so this drops a config option that
has been deprecated with 3.5.

Fixes #33
See https://docs.docker.com/compose/compose-file/compose-file-v3/#external-1

The config claims to be version 3.7, so this drops a config option that
has been deprecated with 3.5.

Fixes #33 
See https://docs.docker.com/compose/compose-file/compose-file-v3/#external-1
@kdambekalns kdambekalns self-assigned this Sep 17, 2021
@kdambekalns kdambekalns marked this pull request as ready for review September 29, 2021 12:45
Copy link
Member

@robertlemke robertlemke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The property "name" was not dropped completely:

image

So, should be:

networks:
  local_beach:
    external: true
    name: local_beach

@kdambekalns
Copy link
Member Author

But the name is taken from the key… as this example in the documentation shows:

networks:
  outside:
    external: true

The name can be used to

specify the name of the network separately from the name used to refer to it within the Compose file

But we don't need that…

@robertlemke robertlemke merged commit 48b6a71 into master Sep 29, 2021
@robertlemke robertlemke deleted the task/33-fix-network-name-config branch September 29, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Network name is set using deprecated option
2 participants