-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TASK: Add Support for Neos 7 #11
Conversation
Mainly because of the adjusted base class for the migrations.
@kdambekalns or @robertlemke it would be great to get this in. If you see a way to make this compatible with oder version i will adjust the pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have another asset source that can be installed on Neos 7 and before, I'll check what I did (or did not) do there…
@kdambekalns the description is corrected, the major problem for compatibility with older neos versions is the change of the doctrine migration base-class. The asset-source api itself only adds two methods that will not do harm in an older Neos. |
@mficzel I checked, and the Canto asset source works with Neos 4.3+ even though the DB migration looks "fresh": https://github.com/flownative/neos-canto/blob/main/Migrations/Mysql/Version20210701152625.php Granted, Pixxio uses I think it's more the PHP version that plays a role here? This is what I checked the Canto asset source against:
|
This reverts commit 04bab15.
@kdambekalns if the migrations are fine it should work in older Neos versions. I relaxed the composer constraint accordingly. |
Adjusted constraints, applied code migrations and implemented icon and description for the AssetSource.
Resolves: #10