Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Add Support for Neos 7 #11

Merged
merged 7 commits into from
Nov 15, 2021
Merged

Conversation

mficzel
Copy link
Contributor

@mficzel mficzel commented Oct 26, 2021

Adjusted constraints, applied code migrations and implemented icon and description for the AssetSource.

Resolves: #10

Mainly because of the adjusted base class for the migrations.
@mficzel
Copy link
Contributor Author

mficzel commented Oct 27, 2021

@kdambekalns or @robertlemke it would be great to get this in.

If you see a way to make this compatible with oder version i will adjust the pr.

Copy link
Member

@kdambekalns kdambekalns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have another asset source that can be installed on Neos 7 and before, I'll check what I did (or did not) do there…

Configuration/Settings.yaml Outdated Show resolved Hide resolved
@mficzel
Copy link
Contributor Author

mficzel commented Oct 27, 2021

@kdambekalns the description is corrected, the major problem for compatibility with older neos versions is the change of the doctrine migration base-class. The asset-source api itself only adds two methods that will not do harm in an older Neos.

@kdambekalns
Copy link
Member

the major problem for compatibility with older neos versions is the change of the doctrine migration base-class.

@mficzel I checked, and the Canto asset source works with Neos 4.3+ even though the DB migration looks "fresh": https://github.com/flownative/neos-canto/blob/main/Migrations/Mysql/Version20210701152625.php

Granted, Pixxio uses Doctrine\DBAL\Migrations\AbstractMigration – but that is available even in a Neos 4.3 setup for me. And could be changed to Doctrine\Migrations\AbstractMigration just fine.

I think it's more the PHP version that plays a role here? This is what I checked the Canto asset source against:

$ php -v
PHP 7.4.25 (cli) (built: Oct 23 2021 18:05:05) ( NTS )
Copyright (c) The PHP Group
Zend Engine v3.4.0, Copyright (c) Zend Technologies
    with Zend OPcache v7.4.25, Copyright (c), by Zend Technologies

$ composer show neos/* doctrine/*
neos/behat                       6.0.x-dev 33c186a  Behat support package for Neos Flow
neos/buildessentials             7.0.x-dev be4e092  Neos Flow Build Toolchain Essentials
neos/composer-plugin             2.1.2              Flow Composer Plugin
neos/demo                        5.0.x-dev 69e7318  Site package for the Neos Demo Site
neos/flow-development-collection 5.3.x-dev 68d0d22  Flow packages in a joined repository for pull requests.
neos/form                        4.3.x-dev 69de421  Extensible and flexible API for building web forms
neos/fusion-afx                  7.2.0              JSX inspired compact syntax for Neos.Fusion
neos/imagine                     3.2.0
neos/neos-development-collection 4.3.x-dev 5b8a412  Neos packages in a joined repository for pull requests.
neos/neos-ui                     4.0.x-dev c74e9dc  Neos CMS UI written in React
neos/neos-ui-compiled            4.0.x-dev 9f909aa
neos/party                       5.0.2              A party package for PHP based on the OASIS Customer Information Quality (CIQ) XML Standard.
neos/seo                         3.2.1              SEO configuration and tools for Neos
neos/setup                       4.0.x-dev 0bed74b  An extensible setup tool for Neos Flow based applications
neos/twitter-bootstrap           dev-master 6defdd8 Simple and flexible HTML, CSS, and Javascript for popular user interface components and interactions. Packaged for use with Neos Flow

@mficzel
Copy link
Contributor Author

mficzel commented Oct 29, 2021

@kdambekalns if the migrations are fine it should work in older Neos versions. I relaxed the composer constraint accordingly.

@kdambekalns kdambekalns merged commit 9a9efce into flownative:master Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not installable on Neos 7
2 participants