Skip to content
This repository has been archived by the owner on Jul 11, 2022. It is now read-only.

coop: loadCaptions still a no-op #19

Closed
phloxic opened this issue Sep 10, 2012 · 8 comments
Closed

coop: loadCaptions still a no-op #19

phloxic opened this issue Sep 10, 2012 · 8 comments
Assignees

Comments

@phloxic
Copy link
Contributor

phloxic commented Sep 10, 2012

@danrossi, @anssip - the captions plugin is still at version 3.2.8, although
http://code.google.com/p/flowplayer-core/issues/detail?id=574
declares this as fixed.

Probably @danrossi's dropbox version fixes it:
https://dl.dropbox.com/u/3394987/flowplayer.captions-3.2.8.zip

Looks like @danrossi's fix never made it into svn (now git).

See also: http://flowplayer.org/forum/4/103398

@ghost ghost assigned danrossi Sep 10, 2012
@phloxic
Copy link
Contributor Author

phloxic commented Sep 10, 2012

Here's a working demo with @danrossi's dev version and 3.2.15:
http://flowplayer.blacktrash.org/test/captionswitch.html

@danrossi
Copy link
Contributor

Hi my fixes were added to svn ages ago, and it is indeed in github. Hmm which file has the problem ? I found there is a build file issue so the plugin isn't compiling correctly.

danrossi added a commit that referenced this issue Sep 11, 2012
@danrossi
Copy link
Contributor

It's working fine here.

@phloxic
Copy link
Contributor Author

phloxic commented Sep 11, 2012

But it was never released. 3.2.8 came out in January, bug report and your fix came later.

@danrossi
Copy link
Contributor

Yes I don't know about that but you were saying it never made it to svn I had to do some digging around and it was all in tact :)

@phloxic
Copy link
Contributor Author

phloxic commented Sep 11, 2012

Ah, I see ;-)

@anssip - I am for testing and pushing just a new captions plugin (after all we have separate versioning) to fix this long-standing bug.

@anssip
Copy link
Contributor

anssip commented Sep 18, 2012

Yep, will release also captions.

@phloxic
Copy link
Contributor Author

phloxic commented Sep 22, 2012

This can be closed.

@phloxic phloxic closed this as completed Sep 22, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants