feat(api-client) HttpOptions usage of reportProgress & withCredentials

* Fixes #45 reportProgress & withCredentials are set from constructor now if available. * automated tests for #45
flowup · May 6, 2018 · 9014a3e · 9014a3e
1 parent 0899b92
commit 9014a3e
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/templates/ngx-service.mustache b/templates/ngx-service.mustache
@@ -31,7 +31,9 @@ export class APIClient {
 
     this.options = {
       headers: options && options.headers ? options.headers : new HttpHeaders(),
-      params: options && options.params ? options.params : new HttpParams()
+      params: options && options.params ? options.params : new HttpParams(),
+      ...(options && options.reportProgress ? { reportProgress: options.reportProgress } : {}),
+      ...(options && options.withCredentials ? { withCredentials: options.withCredentials } : {})
     };
   }
 

diff --git a/tests/esquare/api/api-client.service.ts b/tests/esquare/api/api-client.service.ts
@@ -29,7 +29,9 @@ export class APIClient {
 
     this.options = {
       headers: options && options.headers ? options.headers : new HttpHeaders(),
-      params: options && options.params ? options.params : new HttpParams()
+      params: options && options.params ? options.params : new HttpParams(),
+      ...(options && options.reportProgress ? { reportProgress: options.reportProgress } : {}),
+      ...(options && options.withCredentials ? { withCredentials: options.withCredentials } : {})
     };
   }
 

diff --git a/tests/gcloud-firestore/api/api-client.service.ts b/tests/gcloud-firestore/api/api-client.service.ts
@@ -29,7 +29,9 @@ export class APIClient {
 
     this.options = {
       headers: options && options.headers ? options.headers : new HttpHeaders(),
-      params: options && options.params ? options.params : new HttpParams()
+      params: options && options.params ? options.params : new HttpParams(),
+      ...(options && options.reportProgress ? { reportProgress: options.reportProgress } : {}),
+      ...(options && options.withCredentials ? { withCredentials: options.withCredentials } : {})
     };
   }
 

diff --git a/tests/github/api/api-client.service.ts b/tests/github/api/api-client.service.ts
@@ -29,7 +29,9 @@ export class APIClient {
 
     this.options = {
       headers: options && options.headers ? options.headers : new HttpHeaders(),
-      params: options && options.params ? options.params : new HttpParams()
+      params: options && options.params ? options.params : new HttpParams(),
+      ...(options && options.reportProgress ? { reportProgress: options.reportProgress } : {}),
+      ...(options && options.withCredentials ? { withCredentials: options.withCredentials } : {})
     };
   }