fix: use relative path for artifact file #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please update the tests? thanks! |
Absolute artifact paths break deployment in scenario where serverless package runs in one folder and later serverless deploy runs in a different folder (happens in CI/CD systems). Serverless Framework uses the artifact path to determine the location of the file to copy from. Closes #324
|
@samchungy I updated a few failing unit tests. Could you allow running the test workflow on updated commits? I cannot run the test suite locally because it fails in way too many places (my dev box is Windows and all tests assume Linux in pathnames etc.) |
samchungy
approved these changes
Jul 20, 2022
|
Looks good, sorry it took so long it's been a busy month |
|
🎉 This PR is included in version 1.32.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Absolute artifact paths break deployment in scenario where serverless package runs in one folder
and later serverless deploy runs in a different folder (happens in CI/CD systems).
Serverless Framework uses the artifact path to determine the location of the file to copy from.
Closes #324