[cmake] remove usage of kodi-platform #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pvr.waipu binary addon does not use kodi-platform. Remove existing references from CMakeLists.txt and debian/control. Signed-off-by: Olaf Hering <olaf@aepfle.de>
|
Thanks Olaf for your PR. It looks good to me. kodi-platform is not really needed and can be removed. This pvr plugin is still working without it. Is there any reason other pvr plugins have not yet merged your PR, e.g. kodi-pvr/pvr.hts#415 or palinek/pvr.sledovanitv.cz#31 ? |
|
There was a bug in xbmc/kodi-platform, thats why travis failed. This is now supposed to be fixed. |
|
Hm, nobody else wants to merge. Let's go ahead and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pvr.waipu binary addon does not use kodi-platform.
Remove existing references from CMakeLists.txt and debian/control.