Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): Fix incorrect service method renaming [fixes LNG-199] #757

Merged
merged 3 commits into from
Jun 16, 2023

Conversation

InversionSpaces
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Jun 16, 2023

LNG-199 Fix incorrect service method renaming

service Op("op"):
 someId(a: string) -> string

func foo(someId: string) -> string:
  <- Op.someId(someId)

Produces incorrect air

(seq
 (seq
  (seq
   (call %init_peer_id% ("getDataSrv" "-relay-") [] -relay-)
   (call %init_peer_id% ("getDataSrv" "someId") [] someId)
  )
  (call %init_peer_id% ("op" "someId-0") [someId] someId-0-0)
 )
 (call %init_peer_id% ("callbackSrv" "response") [someId-0-0])
)

Bug introduced while fixing LNG-92

@InversionSpaces InversionSpaces marked this pull request as ready for review June 16, 2023 10:28
@DieMyst DieMyst added the e2e Run e2e workflow label Jun 16, 2023
@InversionSpaces InversionSpaces enabled auto-merge (squash) June 16, 2023 11:09
@InversionSpaces InversionSpaces merged commit e22fff7 into main Jun 16, 2023
@InversionSpaces InversionSpaces deleted the fix/service-methods-renaming branch June 16, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants