Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(execution-engine): remove stream jvaluable implementation #576

Merged
merged 9 commits into from
Apr 13, 2023
Merged

feat(execution-engine): remove stream jvaluable implementation #576

merged 9 commits into from
Apr 13, 2023

Conversation

mikevoronov
Copy link
Member

No description provided.

@mikevoronov mikevoronov added C-enhancement category: an issue proposing an enchacement or a PR with one A-execution-engine area: execution engine of AquaVM labels Apr 11, 2023
@mikevoronov mikevoronov requested a review from monoid April 11, 2023 14:07
@mikevoronov mikevoronov self-assigned this Apr 11, 2023
@linear
Copy link

linear bot commented Apr 11, 2023

VM-286 Remove JValueable implementation for streams

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4668454777

  • 86 of 92 (93.48%) changed or added relevant lines in 6 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.4%) to 83.968%
Changes Missing Coverage Covered Lines Changed/Added Lines %
air/src/execution_step/resolver/resolvable_impl.rs 71 77 92.21%
Files with Coverage Reduction New Missed Lines %
crates/air-lib/lambda/ast/src/ast.rs 1 0%
air/src/execution_step/boxed_value/jvaluable/canon_stream.rs 3 74.19%
Totals Coverage Status
Change from base Build 4660555021: 0.4%
Covered Lines: 15912
Relevant Lines: 18950
💛 - Coveralls

monoid
monoid approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@monoid monoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@monoid monoid added the e2e Run e2e workflow label Apr 13, 2023
@monoid monoid merged commit 513d33a into master Apr 13, 2023
@monoid monoid deleted the feat/VM-286-remove-stream-jvaluable branch April 13, 2023 11:20
@fluencebot fluencebot mentioned this pull request Apr 13, 2023
Merged
@mikevoronov mikevoronov mentioned this pull request May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monoid monoid monoid approved these changes

Assignees

@mikevoronov mikevoronov

Labels
A-execution-engine area: execution engine of AquaVM C-enhancement category: an issue proposing an enchacement or a PR with one e2e Run e2e workflow
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikevoronov @coveralls @monoid