feat: offer-info updates [fixes DXJ-770] #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
folex
reviewed
Jun 24, 2024
|
|
||
| for (const [offerName, offer] of Object.entries(configPerEnv)) { | ||
| const providerAddress = await input({ | ||
| message: `Enter provider address that was used when creating offer ${offerName} with offerId: ${offer.id} at ${configPath}`, |
There was a problem hiding this comment.
Provider address is not stored along with the offers? Maybe it should be?
There was a problem hiding this comment.
this IS the idea in this PR to now store the provider address with the offer
here is the new config type https://github.com/fluencelabs/cli/pull/906/files/181239fe1dea4b3f430e2b79b630e7165016b77e#diff-75e8e297e5ce3647b9b327aa39919ad1bd3d7783560bfc361dba61658c04b15eR122-R125
folex
reviewed
Jun 24, 2024
src/lib/chain/offer.ts
Outdated
| if (notFoundOffersInfo.length > 0) { | ||
| commandObj.warn( | ||
| commandObj.warn( | ||
| `Can't find offer info using the indexer:\n${notFoundOffersInfo |
There was a problem hiding this comment.
User won't know what is an "indexer".
Cannot find the following offers:
- name: id
- name: id
Maybe also print full indexer output in DEBUG in that case. But could be clumsy from the code organisation perspective.
folex
approved these changes
Jun 24, 2024
shamsartem
added a commit
that referenced
this pull request
Sep 9, 2024
* feat: offer-info updates [fixes DXJ-770] * Apply automatic changes * add connection closed to the list of the errors to retry * add debug log * fix? * fix? * improve * updates * Apply automatic changes * update the message * increase ttl * Apply automatic changes --------- Co-authored-by: shamsartem <shamsartem@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.