feat: add provider test #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justprosh
reviewed
Aug 8, 2024
justprosh
reviewed
Aug 8, 2024
justprosh
reviewed
Aug 8, 2024
cli/test/tests/provider.test.ts
Outdated
Comment on lines
136
to
147
| await sleepSeconds(5); | ||
|
|
||
| await fluence({ | ||
| args: ["provider", "cc-info"], | ||
| flags: { | ||
| ...PRIV_KEY_1, | ||
| [OFFER_FLAG_NAME]: NEW_OFFER_NAME, | ||
| }, | ||
| cwd, | ||
| }); | ||
|
|
||
| await sleepSeconds(CC_DURATION_MINUTES * 60); |
There was a problem hiding this comment.
Wow, what do these sleeps mean? You actually wait so long in tests?
There was a problem hiding this comment.
I wait 1 * 60 seconds = 1 minute cause it's a duration of CC. Can we make it less then a minute for this test - probably. I wanted to see all the statuses of the commitment in this test
There was a problem hiding this comment.
It's better to mine blocks in anvil, but I think it requires more work right now
… working on firefox (#994) * fix(cli-connector): switch chain networks reliably, fix connector not working on firefox * don't suggest to switch network if user canceled
justprosh
approved these changes
Aug 8, 2024
shamsartem
added a commit
that referenced
this pull request
Sep 9, 2024
* feat: add provider test * Apply automatic changes * fix * add cc-collateral-withdraw * Apply automatic changes * add offers flag * Apply automatic changes * activate * check cc-info status * fix import and messages * remove asserts * Apply automatic changes * add chain RPC to chain info * add marine and mrepl paths to fluence dep v * Apply automatic changes * improve flags * Apply automatic changes * fix(cli-connector): switch chain networks reliably, fix connector not working on firefox (#994) * fix(cli-connector): switch chain networks reliably, fix connector not working on firefox * don't suggest to switch network if user canceled * use 30 seconds cc duration --------- Co-authored-by: shamsartem <shamsartem@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.