Js client first implementation #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alari
approved these changes
Sep 25, 2018
js-client/README.md
Outdated
| @@ -0,0 +1,120 @@ | |||
| ## IMPORTANT: Client and README are under heavy development and can be outdated. Ask questions in gitter or in issues. | |||
There was a problem hiding this comment.
Ask a question in gitter or file an issue
js-client/gulpfile.js
Outdated
| * limitations under the License. | ||
| */ | ||
|
|
||
| var gulp = require("gulp"); |
js-client/src/ResultAwait.ts
Outdated
| * @param responseTimeoutSec what time to check | ||
| */ | ||
| async result(requestsPerSec: number = 4, responseTimeoutSec = 5): Promise<Result> { | ||
| const path = wrapInQuotes(this.target_key + "/result"); |
There was a problem hiding this comment.
Maybe it's safer to use JSON.stringify instead? So that quotes inside the string are escaped?
| let engine = new Engine(tm); | ||
|
|
||
| // default signing key for now | ||
| let signingKey = "TVAD4tNeMH2yJfkDZBSjrMJRbavmdc3/fGU2N2VAnxT3hAtSkX+Lrl4lN5OEsXjD7GGG7iEewSod472HudrkrA=="; |
There was a problem hiding this comment.
Probably some TODO with explanation should be there?
| } | ||
| } | ||
|
|
||
| const _global = (window /* browser */ || global /* node */) as any; |
There was a problem hiding this comment.
Why do you do it? Why not to simply export the class, and then import it where it's needed?
js-client/src/main.ts
Outdated
| * @param host | ||
| * @param port | ||
| */ | ||
| export async function defaultTest(host: string, port: number) { |
There was a problem hiding this comment.
This test could never fail? Looks like the naming is wrong.
js-client/src/tx.ts
Outdated
| return wrapInQuotes(utils.toHex(Buffer.from(JSON.stringify(json))).toUpperCase()) | ||
| } | ||
|
|
||
| class TxCl { |
js-client/src/utils.ts
Outdated
| */ | ||
|
|
||
| export function wrapInQuotes(str: string): string { | ||
| return "\"" + str + "\"" |
There was a problem hiding this comment.
str could contain quotes inside. Will it be safe in this case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.