-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
download: Add config to set local servers where cache tarballs #270
base: 1.0
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you created the corresponding PR for cerbero upstream as well?
This serves the same purpose as the mirrors features, why can it be used directly? |
When we discussed this, the approach was to use the mirrors but making it prepend the mirror to the list of urls intead of appending it. The community will accept that change as it was proposed as an improvement in my upstream MR but was not finally done that way |
Agree, I commented the same thing to Rubén. Both seem to have a very similar purpose except for the priority. If it's up to me, we could consolidate mirrors by prepending that to the original URL and good to go |
cerbero/cerbero/utils/shell.py Line 459 in 89e4508
|
See for more context https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/148#note_143810 |
Ok. I am going to: 1.- revert my change and prepend the mirror to the list of url. |
This reverts commit 869dec6.
Advantages: 1.- More resilient to upstreams having temporary outages or going away 2. Reduces bandwidth usage for upstreams 3- Easier for orgs/companies to have local mirrors for developers to use Origin: https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/148#note_143810
Usin only the filename in the mirror is an error:
A solution should be use the complete path in the mirror. |
A lot of network errors are happening today. I would like to finish this. As stated in the previous comment, the basename cannot be used because it matches different recipes. ( But if I stop using basename and use the complete path, the official mirror stops working. Like using two lists with different priorities is not an option, I will try to update the official mirror: |
To make gst-plugins-base build happen as GL is forced to build in the recipe, need to install this on ubuntu 18.04 to make it work. Fixes #270 Part-of: <https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/486>
No description provided.