Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download: Add config to set local servers where cache tarballs #270

Open
wants to merge 3 commits into
base: 1.0
Choose a base branch
from

Conversation

rgonzalezfluendo
Copy link
Contributor

No description provided.

Copy link
Contributor

@pamarcos pamarcos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you created the corresponding PR for cerbero upstream as well?

@ylatuya
Copy link
Contributor

ylatuya commented Apr 1, 2020

This serves the same purpose as the mirrors features, why can it be used directly?

@ylatuya
Copy link
Contributor

ylatuya commented Apr 1, 2020

When we discussed this, the approach was to use the mirrors but making it prepend the mirror to the list of urls intead of appending it. The community will accept that change as it was proposed as an improvement in my upstream MR but was not finally done that way

@pamarcos
Copy link
Contributor

pamarcos commented Apr 1, 2020

When we discussed this, the approach was to use the mirrors but making it prepend the mirror to the original URL. The community will accept that change as it was proposed as an improvement in my upstream MR but was not finally done that way

Agree, I commented the same thing to Rubén. Both seem to have a very similar purpose except for the priority. If it's up to me, we could consolidate mirrors by prepending that to the original URL and good to go

@ylatuya
Copy link
Contributor

ylatuya commented Apr 1, 2020

urls += [urllib.parse.urljoin(u + '/', filename) for u in mirrors]

@ylatuya
Copy link
Contributor

ylatuya commented Apr 1, 2020

@rgonzalezfluendo
Copy link
Contributor Author

Ok. I am going to:

1.- revert my change and prepend the mirror to the list of url.
2.- create a cerbero command to automatically syncronize downloaded tarballs.

Advantages:

1.- More resilient to upstreams having temporary outages or going away
2.  Reduces bandwidth usage for upstreams
3-  Easier for orgs/companies to have local mirrors for developers to use

Origin: https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/148#note_143810
@rgonzalezfluendo
Copy link
Contributor Author

Usin only the filename in the mirror is an error:

-----> Checksum failed, tarball /opt/fluendo-codecs-0.10-linux-x86_64/sources/local/openh264-1.7.0/v1.7.0.tar.gz moved to /opt/fluendo-codecs-0.10-linux-x86_64/sources/local/openh264-1.7.0/v1.7.0.tar.gz.failed-checksum
Downloading https://github.com/cisco/openh264/archive/v1.7.0.tar.gz

Recipe 'openh264' failed at the build step 'fetch'
Fatal Error: Checksum for /opt/fluendo-codecs-0.10-linux-x86_64/sources/local/openh264-1.7.0/v1.7.0.tar.gz is '1fec931eb5c94279ad219a5b6e0202358e94a93a90cfb1603578c326abfc1238' instead of '9c07c38d7de00046c9c52b12c76a2af7648b70d05bd5460c8b67f6895738653f'

libvpx.recipe and openh264.recipe has the same filename v1.7.0.tar.gz.

A solution should be use the complete path in the mirror.

@rgonzalezfluendo
Copy link
Contributor Author

rgonzalezfluendo commented Apr 6, 2020

A lot of network errors are happening today. I would like to finish this.

As stated in the previous comment, the basename cannot be used because it matches different recipes. (libvpx.recipe and openh264.recipe has the same filename v1.7.0.tar.gz.)

But if I stop using basename and use the complete path, the official mirror stops working.

Like using two lists with different priorities is not an option, I will try to update the official mirror:
https://gitlab.freedesktop.org/gstreamer/gst-ci/-/issues/18#note_457465

cfoch pushed a commit that referenced this pull request Oct 6, 2022
To make gst-plugins-base build happen as GL is
forced to build in the recipe, need to install
this on ubuntu 18.04 to make it work.

Fixes #270

Part-of: <https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/486>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants