Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download: add retries argument #151

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

dabrain34
Copy link
Contributor

Allow multiple attempts to download an asset

Fix #150

@dabrain34
Copy link
Contributor Author

Confirned with a docker image

@mdimopoulos
Copy link
Contributor

@dabrain34 thanks for the contribution. There is a linter warning in the CI, regarding an exception that is too general. Could you take a look and make it more concrete?

@dabrain34
Copy link
Contributor Author

I disabled the pylint warning as we need to catch some broad exceptions from the downloader.

@ylatuya
Copy link
Contributor

ylatuya commented Nov 20, 2023

I disabled the pylint warning as we need to catch some broad exceptions from the downloader.

I think the type of errors that can be fixed with a retry are all urllib.error.URLError

@mdimopoulos
Copy link
Contributor

mdimopoulos commented Nov 20, 2023

@dabrain34 there is a mypy error Module has no attribute "URLError". Can you check it out please?
You can run make check before pushing to make sure that all linters pass correctly (ref https://github.com/fluendo/fluster#how-can-i-contribute)

Allow multiple attempts to download an asset
@mdimopoulos mdimopoulos merged commit 413bbe2 into fluendo:master Nov 21, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Asset download may fail unexpectedly
3 participants