New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add start-from-head when starttime, endtime, or next_token are present #235

Merged

cosmo0920 merged 2 commits into fluent-plugins-nursery:master from codertao:add-start-from-head

May 9, 2021

codertao commented May 7, 2021

The fix we're using for #234 , based on notes from https://docs.aws.amazon.com/AmazonCloudWatchLogs/latest/APIReference/API_GetLogEvents.html#API_GetLogEvents_RequestSyntax ,

 startFromHead
    If the value is true, the earliest log events are returned first. If the value is false, the latest log events are returned first. The default value is false.
    If you are using nextToken in this operation, you must specify true for startFromHead.
    Type: Boolean
    Required: No


          Add start-from-head when starttime, endtime, or next_token are present

f8d12f8

cosmo0920 approved these changes

View reviewed changes

Member

cosmo0920 left a comment

Looks reasonable for me. 👍


          Extract adding read_from_head clause

83b12d5

This should be for readability.

Signed-off-by: Hiroshi Hatake <cosmo0920.oucc@gmail.com>

cosmo0920 merged commit 3d9337e into fluent-plugins-nursery:master

cosmo0920 mentioned this pull request

in_cloudwatch_logs missing logs when start/end specified #234

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet