Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a separate configuration option for auto creating a log group #254

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cristian-radu
Copy link

I feel like log streams are more dynamic in nature so creating them automatically makes a lot of sense to me.

For example, we use a separate log stream per EC2 instance. However, log groups are fairly static in my environment. We have one per application and would rather manage these through IaC tooling.

It came as a surprise to me that the auto_create_stream option also creates the log group since that is not what the name would suggest. (admittedly, I should have read the docs here more carefully)

I propose adding an "auto_create_group" option as a separate feature.

It may be a breaking change for some deployments, but feels like users should have the option to choose what logging components to auto-create.

Unit tests fail on ruby 2.5, but this is EOL so ignored them.

Not deployed this anywhere yet. Will test it when I get a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant