build: Use flb_strptime() by default #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @fujimotos , few mins ago I did other similar adjustments. Can you adjust this PR and remove that option from the CMake file (actually is not longer needed)? |
Lionel Cons reports that Fluent Bit sometimes adds odd "drift" to timestamps e.g. parsing "10000" with "%s" results in 13600.0 rather than 10000.0. This occurs because "%s" is parsed differently depending on the implementation of strptime(). Some use localtime() internally, and others use gmtime(). This causes the parsed result to vary by the amount of each system's time offset. For this reason, we started to always use our own implementation of strptime(3). Remove the build option as being deprecated. Signed-off-by: Fujimoto Seiji <fujimoto@ceptord.net>
fujimotos
force-pushed
the
sf/use-flb-strptime
branch
from
40c0547
to
d012d88
Compare
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lionel Cons reports that Fluent Bit sometimes adds odd "drift"
to timestamps e.g. parsing "10000" with "%s" results in 13600.0
rather than 10000.0.
This occurs because "%s" is parsed differently depending on the
implementation of strptime(). Some use localtime() internally,
and others use gmtime(). This causes the parsed result to vary
by the amount of each system's time offset.
This patch attempts to fix that issue by defaulting to our own
version of strptime(), and hence makes the behaviour much more
consistent across platforms.
Signed-off-by: Fujimoto Seiji fujimoto@ceptord.net