Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ra_key: handle error case #5997

Merged
merged 2 commits into from
Sep 5, 2022
Merged

Conversation

DavidKorczynski
Copy link
Contributor

flb_sds_create_len may fail and this needs to be handled.

Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=46082

Signed-off-by: David Korczynski david@adalogics.com


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • [N/A ] Example configuration file for the change
  • [N/A ] Debug log output from testing the change
  • [N/A] Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

Documentation

  • [N/A ] Documentation required for this feature

Backporting

  • [N/A ] Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

flb_sds_create_len may fail and this needs to be handled.

Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=46082

Signed-off-by: David Korczynski <david@adalogics.com>
src/flb_ra_key.c Outdated Show resolved Hide resolved
Signed-off-by: David Korczynski <david@adalogics.com>
@DavidKorczynski DavidKorczynski temporarily deployed to pr September 5, 2022 11:53 Inactive
@DavidKorczynski DavidKorczynski temporarily deployed to pr September 5, 2022 11:53 Inactive
@DavidKorczynski DavidKorczynski temporarily deployed to pr September 5, 2022 12:09 Inactive
@edsiper edsiper merged commit 80d0281 into fluent:master Sep 5, 2022
@edsiper edsiper added backport to v1.9.x Used to tag items that must be backported to such version. and removed docs-required labels Sep 5, 2022
@sashashura
Copy link
Contributor

I'm confused why my pull request with exactly same fix was ignored for so long.

edsiper pushed a commit that referenced this pull request Sep 26, 2022
flb_sds_create_len may fail and this needs to be handled.

Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=46082

Signed-off-by: David Korczynski <david@adalogics.com>
edsiper pushed a commit that referenced this pull request Sep 27, 2022
flb_sds_create_len may fail and this needs to be handled.

Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=46082

Signed-off-by: David Korczynski <david@adalogics.com>
mgeriesa pushed a commit to mgeriesa/fluent-bit that referenced this pull request Oct 25, 2022
flb_sds_create_len may fail and this needs to be handled.

Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=46082

Signed-off-by: David Korczynski <david@adalogics.com>
Signed-off-by: Manal Geries <mgeriesa@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport to v1.9.x Used to tag items that must be backported to such version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants