Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved OpenTelemetry OTLP error handling #8962

Merged
merged 3 commits into from
Jun 25, 2024

Conversation

nuclearpidgeon
Copy link
Contributor

Updates to the OpenTelemetry input plugin's HTTP/2 server code to handle/report error cases better.

These were changes I made as part of other work trying to fix #8734 - but I have split them out into a separate PR as I can imagine they may need to be reviewed separately.


Testing requirements

  • Example configuration file for the change:
service:
    log_level: debug
pipeline:
    inputs:
        - name: opentelemetry
          tag_from_uri: true
          http2: true
    outputs:
        - name: 'stdout'
          match: '*'
  • Debug log output from testing the change (will add in update)
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature - don't think so? Although the new HTTP 400 case might warrant documenting.

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Signed-off-by: Stewart Webb <stewart.james.webb@gmail.com>
Signed-off-by: Stewart Webb <stewart.james.webb@gmail.com>
…age in non-ok handling cases

Signed-off-by: Stewart Webb <stewart.james.webb@gmail.com>
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The contents of patch looks good. But we need to handle CI complains which is from commit messages.

Could you use in_opentelemetry: prefix in your commit messages?

@edsiper edsiper merged commit 1c3740d into fluent:master Jun 25, 2024
43 of 44 checks passed
@edsiper
Copy link
Member

edsiper commented Jun 25, 2024

commits were squashed and commit fixed.

@nuclearpidgeon
Copy link
Contributor Author

Somehow missed emails about this the other week. Thanks for cleaning up the commits. Will use the right prefix moving forwards :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tag_from_uri in opentelemetry input plugin has no effect
3 participants