-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved OpenTelemetry OTLP error handling #8962
Improved OpenTelemetry OTLP error handling #8962
Conversation
Signed-off-by: Stewart Webb <stewart.james.webb@gmail.com>
Signed-off-by: Stewart Webb <stewart.james.webb@gmail.com>
…age in non-ok handling cases Signed-off-by: Stewart Webb <stewart.james.webb@gmail.com>
3a57581
to
dbd4997
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contents of patch looks good. But we need to handle CI complains which is from commit messages.
Could you use in_opentelemetry:
prefix in your commit messages?
commits were squashed and commit fixed. |
Somehow missed emails about this the other week. Thanks for cleaning up the commits. Will use the right prefix moving forwards :-) |
Updates to the OpenTelemetry input plugin's HTTP/2 server code to handle/report error cases better.
These were changes I made as part of other work trying to fix #8734 - but I have split them out into a separate PR as I can imagine they may need to be reviewed separately.
Testing requirements
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-test
label to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.