Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

in_elasticsearch: Fix string in http response code 400 #8977

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

lecaros
Copy link
Contributor

@lecaros lecaros commented Jun 18, 2024

It's replying with 400 Forbidden; it should be 400 Bad Request


Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These patches seems fine to me. But, could you use in_elasticsearch: prefix in your commits?

@lecaros lecaros changed the title in_elasticsearch_bulk: Fix string in http response code 400 in_elasticsearch: Fix string in http response code 400 Jun 24, 2024
Signed-off-by: lecaros <lecaros@calyptia.com>
Signed-off-by: lecaros <lecaros@calyptia.com>
@lecaros
Copy link
Contributor Author

lecaros commented Jun 24, 2024

@cosmo0920 Just changed the commit messages.
Thanks

@cosmo0920 cosmo0920 added this to the Fluent Bit v3.1.7 milestone Aug 22, 2024
@cosmo0920
Copy link
Contributor

This is trivial fix but I added v3.1.7 mile stone for not overlooking to merge this PR.

@edsiper edsiper merged commit cd659c5 into master Aug 27, 2024
46 checks passed
@edsiper edsiper deleted the lecaros-elastic-http-response branch August 27, 2024 15:01
legendary-acp pushed a commit to ctrlb-hq/ctrlb-fluent-bit that referenced this pull request Oct 1, 2024
* in_elasticsearch: Fix string in http response code 400.

Signed-off-by: lecaros <lecaros@calyptia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants