Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiline #10

Merged
merged 14 commits into from
Nov 17, 2015
Merged

Support multiline #10

merged 14 commits into from
Nov 17, 2015

Conversation

okkez
Copy link
Collaborator

@okkez okkez commented Nov 12, 2015

No description provided.

@okkez
Copy link
Collaborator Author

okkez commented Nov 12, 2015

There are some problems in this implementation.

  • %{GREEDYDATA} does not much multiline
    • so test is failed, for now.
  • In parse(text), text does not include line break.
    • Maybe this line break is deleted by fluentd automatically.
    • Should we append line break?
  • This plugin cannot process last record forever
    • How to detect the end of last record?

Request for comments, please.
Thanks.

@okkez
Copy link
Collaborator Author

okkez commented Nov 12, 2015

This is for #6

@visualphoenix
Copy link

maybe it can buffer until an end regex is matched or until the start regex matches again? Obviously this would not work for multiple workers (same problem as multiline in logstash)

@visualphoenix
Copy link

could also possibly flush out after a timeout

@visualphoenix
Copy link

for parser problem maybe check how they did multilinecsv? https://github.com/fluent/fluentd/pull/543/files

@okkez
Copy link
Collaborator Author

okkez commented Nov 13, 2015

Thank you for your comment!

maybe it can buffer until an end regex is matched or until the start regex matches again?

Yes, I think so, too.

could also possibly flush out after a timeout

Maybe, this is fluentd's in_tail plugin's issue.
I will check fluentd's in_tail plugin codes.

@kiyoto kiyoto mentioned this pull request Nov 13, 2015
@okkez
Copy link
Collaborator Author

okkez commented Nov 16, 2015

@visualphoenix How about 9f3b25f and db49d34?

@visualphoenix
Copy link

Looks good to me. We can invent new refinements as we use it more.

On Monday, November 16, 2015, okkez notifications@github.com wrote:

@visualphoenix https://github.com/visualphoenix How about 9f3b25f
9f3b25f
and db49d34
db49d34
?


Reply to this email directly or view it on GitHub
#10 (comment)
.

Raymond "VisualPhoenix" Barbiero

@okkez okkez changed the title WIP: Support multiline Support multiline Nov 17, 2015
okkez added a commit that referenced this pull request Nov 17, 2015
@okkez okkez merged commit 66ec245 into fluent:master Nov 17, 2015
@okkez
Copy link
Collaborator Author

okkez commented Nov 17, 2015

Thanks merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants