-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiline #10
Conversation
There are some problems in this implementation.
Request for comments, please. |
This is for #6 |
maybe it can buffer until an end regex is matched or until the start regex matches again? Obviously this would not work for multiple workers (same problem as multiline in logstash) |
could also possibly flush out after a timeout |
for parser problem maybe check how they did multilinecsv? https://github.com/fluent/fluentd/pull/543/files |
Thank you for your comment!
Yes, I think so, too.
Maybe, this is fluentd's in_tail plugin's issue. |
Because we need to set multiline mode or not before setup parsers.
We need more tests.
This is similar to in_tail's multiline format. See also http://docs.fluentd.org/articles/in_tail
This reverts commit eaea10d. This commit is confuse for users.
In this case, single grok pattern must suppose text format perfectly.
@visualphoenix How about 9f3b25f and db49d34? |
Looks good to me. We can invent new refinements as we use it more. On Monday, November 16, 2015, okkez notifications@github.com wrote:
Raymond "VisualPhoenix" Barbiero |
We need to describe that how it works.
Thanks merged. |
No description provided.