Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chomp! deletes last valid byte and should be removed in socket_util.rb line 47 #1741

Closed
mpergament opened this issue Nov 8, 2017 · 3 comments
Closed

Chomp! deletes last valid byte and should be removed in socket_util.rb line 47 #1741

mpergament opened this issue Nov 8, 2017 · 3 comments
Assignees
@repeatedly
Labels
enhancement Feature request or improve operations

Comments

@mpergament
Copy link

Chomp! removes valid bytes from binary stream which caused a problem in Google protobuf decoding as last byte 0xOA (\n) was removed by this statement. Line 47 should be removed
@repeatedly
Copy link
Member

repeatedly commented Nov 10, 2017 •
edited
Loading

You mean in_udp plugin?
If so, adding new parameter, e.g. remove_newline, is better.
How about this?

@repeatedly repeatedly self-assigned this Nov 13, 2017
@repeatedly repeatedly added the enhancement Feature request or improve operations label Nov 13, 2017
@repeatedly
Copy link
Member

Patch is here: #1747

repeatedly added a commit that referenced this issue Nov 14, 2017
@repeatedly
Merge pull request #1747 from fluent/in_udp-add-remove_newline
6205781 
in_udp: Add remove_newline parameter. fix #1741
@mpergament
Copy link
Author

Remove_newline default must be false not true as in a first place it does not make much sense to remove anything in in_udp

This was referenced Nov 14, 2017
Open
Open
@3fr61n 3fr61n mentioned this issue Nov 22, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@repeatedly repeatedly

Labels
enhancement Feature request or improve operations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@repeatedly @mpergament