Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system: Add worker_id to process_name when workers is larger than 1 #2321

Merged
merged 1 commit into from
Mar 12, 2019

Conversation

repeatedly
Copy link
Member

@repeatedly repeatedly commented Mar 1, 2019

Signed-off-by: Masahiro Nakagawa repeatedly@gmail.com

Which issue(s) this PR fixes:
No entry.

What this PR does / why we need it:
Currently, worker's process names are same when workers > 1. This patch improves such case like below:

% ps aux | grep fluentd
repeatedly        7923   0.0  0.1  2521484  21240 s010  S+    4:25AM   0:00.83 worker:fluentd3     
repeatedly        7922   0.0  0.1  2519436  17984 s010  S+    4:25AM   0:00.82 worker:fluentd2     
repeatedly        7921   0.0  0.1  2522520  18676 s010  S+    4:25AM   0:00.86 worker:fluentd1     
repeatedly        7920   0.0  0.1  2522520  23420 s010  S+    4:25AM   0:00.88 worker:fluentd0     
repeatedly        7892   0.0  0.1  2523544  10260 s010  S+    4:25AM   0:00.65 supervisor:fluentd 

Docs Changes:
Need multi worker article update.

Release Note:

See PR title.

@repeatedly repeatedly added the enhancement Feature request or improve operations label Mar 1, 2019
@repeatedly repeatedly self-assigned this Mar 1, 2019
@repeatedly repeatedly requested a review from okkez March 1, 2019 19:39
Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
@repeatedly repeatedly force-pushed the add-worker-id-to-process-name branch from c4f94ec to 4bf14fd Compare March 6, 2019 01:24
@repeatedly
Copy link
Member Author

@okkez Could you also check this patch?

Copy link
Contributor

@okkez okkez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay.
Looks nice!

@repeatedly repeatedly merged commit eae8611 into master Mar 12, 2019
@ganmacs ganmacs deleted the add-worker-id-to-process-name branch July 11, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request or improve operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants