Correct fluentd helm tests #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pecastro
force-pushed
the
fluentd-440-pecastro
branch
7 times, most recently
from
7c8bf6d
to
29db732
Compare
Signed-off-by: Paulo E. Castro <pecastro@wormholenet.com>
Signed-off-by: Paulo E. Castro <pecastro@wormholenet.com>
Signed-off-by: Paulo E. Castro <pecastro@wormholenet.com>
It will time-out after 5 min if things are really broken in line with the helm test default. Signed-off-by: Paulo E. Castro <pecastro@wormholenet.com>
pecastro
force-pushed
the
fluentd-440-pecastro
branch
from
29db732
to
4a505ec
Compare
|
@dioguerra Please have a look... |
dioguerra
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a few tweaks to make the current default values a bit more complete from a working out of the box perspective and to enable the existing test to pass.
Related to #440