Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hint association and attribute passthrough for radio buttons #72

Merged
merged 2 commits into from
Sep 7, 2021
Merged

feat: add hint association and attribute passthrough for radio buttons #72

merged 2 commits into from
Sep 7, 2021

Conversation

greatislander
Copy link
Contributor

Resolves #69, resolves #70.

@greatislander greatislander added the enhancement New feature or request label Sep 7, 2021
@greatislander greatislander self-assigned this Sep 7, 2021
@greatislander greatislander enabled auto-merge (squash) September 7, 2021 15:42
@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #72 (e5ae1bd) into main (b313221) will increase coverage by 2.42%.
The diff coverage is 100.00%.

❗ Current head e5ae1bd differs from pull request most recent head 1528a66. Consider uploading reports for the commit 1528a66 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main      #72      +/-   ##
============================================
+ Coverage     37.57%   40.00%   +2.42%     
  Complexity       62       62              
============================================
  Files            19       19              
  Lines           322      325       +3     
============================================
+ Hits            121      130       +9     
+ Misses          201      195       -6     
Impacted Files Coverage Δ
src/Components/RadioButtons.php 100.00% <100.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b313221...1528a66. Read the comment docs.

@greatislander greatislander merged commit 848853d into fluid-project:main Sep 7, 2021
@greatislander greatislander deleted the feat/radio-group-improvements branch September 7, 2021 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add attribute passthrough for radio buttons Add hint association capability for radio buttons
1 participant