Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate Eleventy Navigation plugin #196

Merged
merged 2 commits into from
May 10, 2021

Conversation

greatislander
Copy link
Contributor

@greatislander greatislander commented May 7, 2021

I've configured the main navigation to use Eleventy's navigation system. Replacing the docs manifest file poses some issues because some items appear as the children of multiple sections (e.g. the DOM Binder API which appears under both 'API' and 'Views'). I think it would be worth examining the structure prior to any further changes (and I still think embedding navigation/TOC structure in documentation makes more sense than maintaining a parallel manifest file) — however, this PR is now ready for review and merge as is.

@greatislander greatislander self-assigned this May 7, 2021
@greatislander greatislander marked this pull request as ready for review May 7, 2021 16:40
@greatislander greatislander added the enhancement New feature or request label May 7, 2021
@cindyli cindyli merged commit 4e28ea3 into fluid-project:main May 10, 2021
@cindyli
Copy link
Member

cindyli commented May 10, 2021

resolves #191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants