nomad jobs deploy #741
nomad jobs deploy #741
Conversation
- Add nomad deploy job - Hashicorp's `hcl` parser can read plain `json`, as well, hence jobs can be defined in `json`, or `nix` rendered to `json`
- Capture nomad secrets from env variables - Analog to terraform
- Encapsulate nomad deploy as module
- Generate deploy tasks for an entire deploy job tree.
blaggacao
force-pushed
the
nomad-jobs-deploy
branch
from
937ac0a
to
6ea55c6
Compare
|
Just in time for me to starting testing. Thank you for this! |
| value = deployNomad { | ||
| inherit setup; | ||
| inherit name; | ||
| src = "." + src; |
There was a problem hiding this comment.
@kamadorueda If we have nix rendered to nomad / terraform jobs json files, then we probably need a different way of specifying those files here in addition to a str.
We could, for example, accept store paths, as well.
There was a problem hiding this comment.
It's okay what you say, please use the interface that fits your needs
If you are talking about: #619 , I think it's better to handle that in other PR
|
Looks good to me, I would merge as it is. I would also merge 4 small PRs, one for each arg/module, so things land For ensuring long-term support please consider adding docs and tests With tests we ensure we are not breaking something accidentally (Nix is lazy and failures can go unnoticed) |
|
I would say, if my tests are successful, that we should just merge as is and add docs and tests later, unless that's something you'd like to include before opening for official review @blaggacao. In any case, my testing of this is currently blocked by #742 so I need to get that sorted before I actually know for sure if this works as is. |
|
I would merge as is, as long as existing CI tests pass So, what you feel more comfortable with I will agree. Thanks for sharing your work! |
|
It could be that there is some small bug in the implementation that we won't know about until I am able to test it though. Seems like good practice to actually try a feature set before committing it no? |
|
I'll add tests & docs and we can merge based on that in separate PRs and leave the end2end testing pending. |
deployNomadJobanalog todeployTerraform#615 nomad deploy jobdeployNomadJobanalog todeployTerraform#615 make nomad secretsdeployNomadJobanalog todeployTerraform#615 nomad deploy moduledeployNomadJobanalog todeployTerraform#615 nomad deploy ns module