Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Extension Instantiation with Variadic Options #5

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

frisbm
Copy link
Collaborator

@frisbm frisbm commented Mar 14, 2023

Description

Better Extension Instantiation with Variadic Options

Motivation and Context

It was too verbose to require the values be set when they weren't required

How Has This Been Tested?

Tested the generation with/without the option and ensured the tests ran successfully

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update or addition to documentation for this project)

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@frisbm frisbm merged commit 09f006a into main Mar 14, 2023
@frisbm frisbm deleted the better-instantiation-with-options branch March 14, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant