Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement filtering by datatype #576

Closed
zonotope opened this issue Sep 14, 2023 · 3 comments
Closed

Implement filtering by datatype #576

zonotope opened this issue Sep 14, 2023 · 3 comments
Milestone
3.0.0-beta2

Comments

@zonotope
Copy link
Contributor

We should allow users to filter query results by datatype both by specifying a datatype iri explicitly tied to an item in a query through a value map that should work similarly to SPARQLs ^^ syntax as well as implementing the datatype query function

We should support similar functionality for querying datatypes as we do for language tags
@zonotope zonotope added this to the 3.0.0-beta2 milestone Sep 14, 2023
@cap10morgan cap10morgan self-assigned this Oct 25, 2023
@cap10morgan cap10morgan changed the title Impliment filtering by datatype Implement filtering by datatype Oct 25, 2023
@cap10morgan
Copy link
Contributor

cap10morgan commented Oct 26, 2023 •
edited
Loading

This is blocked by deterministic SIDs because otherwise the SID -> IRI lookup is async, and query functions can't be async.

That's only true for custom datatypes which we don't fully support yet anyway. We can statically map the built-in datatype SIDs to IRIs in the code and use that (some of them already are mapped in the predefined-properties map).

@cap10morgan
Copy link
Contributor

I have some of this done already, but feel free to pick it up. Just ping me and I can share what I already have done.

This was referenced Oct 25, 2023
Merged
Merged
Merged
Merged
@cap10morgan cap10morgan removed their assignment Oct 26, 2023
cap10morgan added a commit that referenced this issue Oct 27, 2023
@cap10morgan
Fix code formatting in f.d.q.fql-test (#607)
d8ace2d 
Part of my work on #576
cap10morgan added a commit that referenced this issue Oct 27, 2023
@cap10morgan
Add a pending test for the datatype query fn (#608)
5923e7d 
This introduces a new ^:pending test metadata that we should filter out
of regular test runs if we end up adopting it. I may introduce that in a
subsequent PR. If nothing ever comes of that, feel free to remove it.

Part of my work on #576
cap10morgan added a commit that referenced this issue Oct 27, 2023
@cap10morgan
Remove redundant starting value in a sum reduce (#609)
4d6cdff 
Just something I noticed while working on #576
@zonotope
Copy link
Contributor Author

Implemented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0-beta2
Development

No branches or pull requests
2 participants
@cap10morgan @zonotope