-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix orderBy var in optional part of where clause #196
Conversation
I think this was supposed to have a "not" here all along.
...call for optional clause
...in variable-in-where?
(= type :binding) (= (:variable where-smt) variable) | ||
(= type :union) (or (variable-in-where? variable (first (:where where-smt))) | ||
(variable-in-where? variable (second (:where where-smt))))))) | ||
(case type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this case
exhaustive? I sometimes prefer cond
unless I know that the case
is exhaustive, since it will blow up on a missing case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that's probably what @bplatz was referring to. I think we want it to ignore other types, so I'll add a default that does that.
It should ignore unknown where-smt types
Fixes FC-1430
I think the error message was missing a "not" it was intended to have all along. Using
map
for the recursive search of theoptional
clause would give a collection of bool-ish values instead of one,so I changed that toAnd then we fixed several other issues.some
instead (like the outer logic uses).