Fix orderBy var in optional part of where clause #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this was supposed to have a "not" here all along.
...call for optional clause
...in variable-in-where?
bplatz
approved these changes
Sep 7, 2022
dpetran
reviewed
Sep 7, 2022
| (= type :binding) (= (:variable where-smt) variable) | ||
| (= type :union) (or (variable-in-where? variable (first (:where where-smt))) | ||
| (variable-in-where? variable (second (:where where-smt))))))) | ||
| (case type |
There was a problem hiding this comment.
Is this case exhaustive? I sometimes prefer cond unless I know that the case is exhaustive, since it will blow up on a missing case.
There was a problem hiding this comment.
Ah, that's probably what @bplatz was referring to. I think we want it to ignore other types, so I'll add a default that does that.
It should ignore unknown where-smt types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes FC-1430
I think the error message was missing a "not" it was intended to have all along. Using
mapfor the recursive search of theoptionalclause would give a collection of bool-ish values instead of one,so I changed that toAnd then we fixed several other issues.someinstead (like the outer logic uses).