-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ungrouped aggregations; group before ordering #265
Conversation
This reverts commit 8784699. Temporarily reverting this commit to get tests to pass
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks really good. Not sure if you have a sense on why the test is failing.
Realize this is a draft, but would be great to get it committed since it touches highly volatile files at the moment, don't want to create a more challenging time getting it merged later (or vice versa for other merges).
This is a new (or, at least newly uncommented) test. It's failing in cljs, but I reflexively made it a cljc file when all the other tests are clj. I've changed it to a clj file and will add an issue to make the tests we need work in cljs. |
This patch computes ungrouped queries with aggregation functions as if all results are in a single implicit group, supporting queries like:
This patch also changes the grouping algorithm to avoid needing to sort the result set if there's no order-by clause specified.
This builds on #263, so take a look at that one first.
closes #239