Fix :spot error on query #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSC strategy provides no advantage here, so we process these as regular queries.
We now exclude queries with any ['?s '?p '?o] clauses, not just those where that is the sole clause
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #356
This error was being caused by the fact that it was going through the simple-subject-crawl pipeline, which is not meant for this type of query.
This PR updates the SSC reparsing logic to reject this query, so it's processed by the main query pipeline instead.
Also adds a test for the expected output of this query. I originally thought this output was a bug, and opened #384 to address it, but it may not in fact be a bug.
If this output is actually correct, we can close #384