Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix :spot error on query #389

Merged
merged 3 commits into from
Feb 17, 2023
Merged

Fix :spot error on query #389

merged 3 commits into from
Feb 17, 2023

Conversation

mpoffald
Copy link
Contributor

@mpoffald mpoffald commented Feb 16, 2023

Fixes #356

This error was being caused by the fact that it was going through the simple-subject-crawl pipeline, which is not meant for this type of query.

This PR updates the SSC reparsing logic to reject this query, so it's processed by the main query pipeline instead.

Also adds a test for the expected output of this query. I originally thought this output was a bug, and opened #384 to address it, but it may not in fact be a bug.

If this output is actually correct, we can close #384

SSC strategy provides no advantage here, so we process these as regular queries.
@mpoffald mpoffald requested a review from a team February 16, 2023 21:09
We now exclude queries with any ['?s '?p '?o] clauses, not just those where that is the sole clause
Copy link
Contributor

@zonotope zonotope left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪂

@mpoffald mpoffald merged commit 257bb6e into main Feb 17, 2023
@mpoffald mpoffald deleted the fix/subgraph-spo-query branch February 17, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

full-db query with subgraph selector returns repeated results :spot error on query
2 participants