Fix multiple property SHACL shapes #488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into implementing the
sh:and
logical constraint, I wanted to ensure that multiple properties in a single shape was already working. I noticed that we didn't have any tests for that yet so wanted to start there. It wasn't yet working with a combination of cardinality (e.g.sh:minCount
) and value range (e.g.sh:minExclusive
) constraints.This adds a test for that and fixes it in a minimally-invasive way (for now).
Part of #321